Trevor Parscal has uploaded a new change for review.
https://gerrit.wikimedia.org/r/65452
Change subject: Restore window overlays
......................................................................
Restore window overlays
And use them for the category widget for it's popup.
Change-Id: I43db14c749400efa6a770343afbdfa16dd6bff30
---
M modules/ve/ui/dialogs/ve.ui.MWMetaDialog.js
M modules/ve/ui/styles/ve.ui.Window.css
M modules/ve/ui/ve.ui.Window.js
3 files changed, 14 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/52/65452/1
diff --git a/modules/ve/ui/dialogs/ve.ui.MWMetaDialog.js
b/modules/ve/ui/dialogs/ve.ui.MWMetaDialog.js
index 5dfa2eb..24a967b 100644
--- a/modules/ve/ui/dialogs/ve.ui.MWMetaDialog.js
+++ b/modules/ve/ui/dialogs/ve.ui.MWMetaDialog.js
@@ -62,7 +62,7 @@
'$$': this.frame.$$, 'label': ve.msg(
'visualeditor-dialog-meta-categories-settings-label' ), 'icon': 'settings'
} );
this.categoryWidget = new ve.ui.MWCategoryWidget( {
- '$$': this.frame.$$, '$overlay': this.surface.$globalOverlay
+ '$$': this.frame.$$, '$overlay': this.$overlay
} );
this.defaultSortInput = new ve.ui.TextInputWidget( {
'$$': this.frame.$$, 'placeholder': this.fallbackDefaultSortKey
diff --git a/modules/ve/ui/styles/ve.ui.Window.css
b/modules/ve/ui/styles/ve.ui.Window.css
index 0142ff5..fb7a1fc 100644
--- a/modules/ve/ui/styles/ve.ui.Window.css
+++ b/modules/ve/ui/styles/ve.ui.Window.css
@@ -38,3 +38,13 @@
white-space: nowrap;
cursor: default;
}
+
+.ve-ui-window-overlay {
+ font-family: sans-serif;
+ line-height: 1.5em;
+ font-size: 1em;
+ position: absolute;
+ top: 0;
+ left: 0;
+ z-index: 1000;
+}
diff --git a/modules/ve/ui/ve.ui.Window.js b/modules/ve/ui/ve.ui.Window.js
index 85a6591..62d45fa 100644
--- a/modules/ve/ui/ve.ui.Window.js
+++ b/modules/ve/ui/ve.ui.Window.js
@@ -171,12 +171,14 @@
this.$head = this.$$( '<div class="ve-ui-window-head"></div>' );
this.$body = this.$$( '<div class="ve-ui-window-body"></div>' );
this.$foot = this.$$( '<div class="ve-ui-window-foot"></div>' );
+ this.$overlay = this.$$( '<div class="ve-ui-window-overlay"></div>' );
// Initialization
this.frame.$content.append(
this.$head.append( this.$icon, this.$title ),
this.$body,
- this.$foot
+ this.$foot,
+ this.$overlay
);
};
--
To view, visit https://gerrit.wikimedia.org/r/65452
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I43db14c749400efa6a770343afbdfa16dd6bff30
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Trevor Parscal <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
