jenkins-bot has submitted this change and it was merged.
Change subject: Fix getAnnotationIndexesFromOffset() to always return an array
......................................................................
Fix getAnnotationIndexesFromOffset() to always return an array
It used to, but a recent change broke it
Change-Id: I03ecfd5a515855a286136b57217779fd1c5912a5
---
M modules/ve/dm/lineardata/ve.dm.ElementLinearData.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Esanders: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/dm/lineardata/ve.dm.ElementLinearData.js
b/modules/ve/dm/lineardata/ve.dm.ElementLinearData.js
index f02dd99..b608208 100644
--- a/modules/ve/dm/lineardata/ve.dm.ElementLinearData.js
+++ b/modules/ve/dm/lineardata/ve.dm.ElementLinearData.js
@@ -323,7 +323,7 @@
if ( typeof element === 'string' ) {
return [];
} else {
- return element.annotations || element[1];
+ return element.annotations || element[1] || [];
}
};
--
To view, visit https://gerrit.wikimedia.org/r/65430
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I03ecfd5a515855a286136b57217779fd1c5912a5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
