jenkins-bot has submitted this change and it was merged.
Change subject: Don't do evil shadowing of mw
......................................................................
Don't do evil shadowing of mw
Having local variable called mw that shadows the global variable mw
is evil. Rename it to mwAttr.
Change-Id: I87bd3698c73608076424c10fdb0559dfdc3e3045
---
M modules/ve/dm/nodes/ve.dm.MWReferenceNode.js
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/dm/nodes/ve.dm.MWReferenceNode.js
b/modules/ve/dm/nodes/ve.dm.MWReferenceNode.js
index c363521..54198ea 100644
--- a/modules/ve/dm/nodes/ve.dm.MWReferenceNode.js
+++ b/modules/ve/dm/nodes/ve.dm.MWReferenceNode.js
@@ -57,7 +57,7 @@
};
ve.dm.MWReferenceNode.static.toDomElements = function ( dataElement, doc,
converter ) {
- var itemNodeHtml, mw,
+ var itemNodeHtml, mwAttr,
span = doc.createElement( 'span' ),
itemNodeWrapper = doc.createElement( 'div' ),
itemNode = converter.internalList.getItemNode(
dataElement.attributes.listIndex ),
@@ -72,9 +72,9 @@
),
itemNodeHtml = $( itemNodeWrapper ).html();
- mw = ( dataElement.attributes && ve.copyObject(
dataElement.attributes.mw ) ) || {};
- ve.setProp( mw, 'body', 'html', itemNodeHtml );
- span.setAttribute( 'data-mw', JSON.stringify( mw ) );
+ mwAttr = ( dataElement.attributes && ve.copyObject(
dataElement.attributes.mw ) ) || {};
+ ve.setProp( mwAttr, 'body', 'html', itemNodeHtml );
+ span.setAttribute( 'data-mw', JSON.stringify( mwAttr ) );
return [ span ];
};
--
To view, visit https://gerrit.wikimedia.org/r/65601
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I87bd3698c73608076424c10fdb0559dfdc3e3045
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
