Tobias Gritschacher has submitted this change and it was merged.
Change subject: Checking for valid qualifiers in claimview
......................................................................
Checking for valid qualifiers in claimview
(bug 48776)
Change If4e1196551835776100382416430ae289f82c825 caused claimview's save button
to be enabled
with empty qualifiers being present.
Change-Id: Iaa8636e8878abb379681be3e3ca44174ecc2fc44
---
M lib/resources/jquery.wikibase/jquery.wikibase.claimview.js
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Tobias Gritschacher: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.claimview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.claimview.js
index 6344718..3ba48ca 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.claimview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.claimview.js
@@ -184,6 +184,10 @@
* @return {boolean}
*/
isValid: function() {
+ if( this._qualifiers && !this._qualifiers.isValid() ) {
+ return false;
+ }
+
try {
this._instantiateClaim( null );
} catch( e ) {
--
To view, visit https://gerrit.wikimedia.org/r/65660
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa8636e8878abb379681be3e3ca44174ecc2fc44
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: mw1.22-wmf5
Gerrit-Owner: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: Henning Snater <[email protected]>
Gerrit-Reviewer: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
