jenkins-bot has submitted this change and it was merged.
Change subject: Don't show anonymous users tipsy with setlang
......................................................................
Don't show anonymous users tipsy with setlang
Bug: 47970
Change-Id: Ib7744b2d5f826ed781fff8359b5a4482b0bda522
---
M resources/js/ext.uls.interface.js
1 file changed, 11 insertions(+), 3 deletions(-)
Approvals:
Nikerabbit: Looks good to me, approved
Siebrand: Checked
jenkins-bot: Verified
diff --git a/resources/js/ext.uls.interface.js
b/resources/js/ext.uls.interface.js
index 7516a95..c90a678 100644
--- a/resources/js/ext.uls.interface.js
+++ b/resources/js/ext.uls.interface.js
@@ -117,10 +117,11 @@
* It also allows to undo the language selection.
*/
function showULSTooltip() {
- var $ulsTrigger = $( '.uls-trigger' ),
- ulsPosition = mw.config.get( 'wgULSPosition' ),
+ var ulsPosition = mw.config.get( 'wgULSPosition' ),
currentLang = mw.config.get( 'wgUserLanguage' ),
previousLang,
+ $ulsTrigger,
+ anonMode,
rtlPage = $( 'body' ).hasClass( 'rtl' ),
tipsyGravity = {
personal: 'n',
@@ -135,10 +136,17 @@
return true;
}
+ $ulsTrigger = ( ulsPosition === 'interlanguage' ) ?
+ $( '.uls-settings-trigger' ) :
+ $( '.uls-trigger' );
+
previousLanguages.push( currentLang );
mw.uls.setPreviousLanguages( previousLanguages );
- if ( !previousLang || !$.uls.data.languages[previousLang] ) {
+ anonMode = ( mw.user.isAnon() &&
+ !mw.config.get( 'wgULSAnonCanChangeLanguage' )
);
+
+ if ( anonMode || !previousLang ||
!$.uls.data.languages[previousLang] ) {
// Do not show tooltip
return true;
}
--
To view, visit https://gerrit.wikimedia.org/r/63848
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib7744b2d5f826ed781fff8359b5a4482b0bda522
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Amire80 <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: Pginer <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
