jenkins-bot has submitted this change and it was merged.
Change subject: wikibits: Wrap jsMsg in mw.log.deprecate
......................................................................
wikibits: Wrap jsMsg in mw.log.deprecate
No release notes since it was already deprecated (in 1.17 to
mw.util.jsMessage and in 1.20 to mediawiki.notify, though we
don't fallback to that directly since it is not compatible).
Change-Id: I359c94929e58363d5b38f410a60b456111bb0897
---
M resources/mediawiki/mediawiki.util.js
M skins/common/wikibits.js
2 files changed, 3 insertions(+), 5 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/mediawiki/mediawiki.util.js
b/resources/mediawiki/mediawiki.util.js
index 481929d..977929d 100644
--- a/resources/mediawiki/mediawiki.util.js
+++ b/resources/mediawiki/mediawiki.util.js
@@ -460,7 +460,7 @@
*
* @param {Mixed} message The DOM-element, jQuery object or
HTML-string to be put inside the message box.
* to allow CSS/JS to hide different boxes. null = no class
used.
- * @deprecated Use mw#notify
+ * @deprecated since 1.20 Use mw#notify
*/
jsMessage: function ( message ) {
if ( !arguments.length || message === '' || message ===
null ) {
diff --git a/skins/common/wikibits.js b/skins/common/wikibits.js
index 1a9aabc..93bf1ad 100644
--- a/skins/common/wikibits.js
+++ b/skins/common/wikibits.js
@@ -396,11 +396,9 @@
* something, replacing any preexisting message.
*
* @deprecated since 1.17 Use the 'mediawiki.notify' module instead.
- * @param {String|HTMLElement} message To be put inside the message box.
+ * @param {string|HTMLElement} message To be put inside the message box.
*/
-window.jsMsg = function () {
- return mw.util.jsMessage.apply( mw.util, arguments );
-};
+mw.log.deprecate( window, 'jsMsg', mw.util.jsMessage, 'Use mediawiki.notify
instead.' );
/**
* Inject a cute little progress spinner after the specified element
--
To view, visit https://gerrit.wikimedia.org/r/60268
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I359c94929e58363d5b38f410a60b456111bb0897
Gerrit-PatchSet: 10
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Daniel Friesen <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Matmarex <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: Trevor Parscal <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
