Jeroen De Dauw has submitted this change and it was merged.
Change subject: remove hardcoded "ERROR: TODO: ..." output from
TypedValueFormatter
......................................................................
remove hardcoded "ERROR: TODO: ..." output from TypedValueFormatter
- otherwise this gets outputted in the client when using {{#property}} with a
time data value
Change-Id: Ib8f775b092bc1a02a97784d721bef97eda9676dd
---
M lib/includes/TypedValueFormatter.php
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Ataherivand: Looks good to me, but someone else must approve
Jeroen De Dauw: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/includes/TypedValueFormatter.php
b/lib/includes/TypedValueFormatter.php
index 4cedb67..06ce802 100644
--- a/lib/includes/TypedValueFormatter.php
+++ b/lib/includes/TypedValueFormatter.php
@@ -58,8 +58,9 @@
return $value;
}
- // TODO: implement: error message or other error
handling
- return 'ERROR: TODO: getValue returned non-string, so
DataType is missing formatter';
+ // @todo: implement: error message or other error
handling
+ // @todo: implement value formatter for time!
+ return '';
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/65965
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib8f775b092bc1a02a97784d721bef97eda9676dd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <[email protected]>
Gerrit-Reviewer: Ataherivand <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Denny Vrandecic <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
