Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/66017
Change subject: Cleanup: Kill unused getPageArrayFromApiResponse
......................................................................
Cleanup: Kill unused getPageArrayFromApiResponse
Not used in code base so killing. Using $.map instead
Change-Id: I6ba5ce48d1debc7956a4f6253a568ee1059aa4a9
---
M javascripts/common/mf-application.js
1 file changed, 0 insertions(+), 13 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/17/66017/1
diff --git a/javascripts/common/mf-application.js
b/javascripts/common/mf-application.js
index ee23735..d5181db 100644
--- a/javascripts/common/mf-application.js
+++ b/javascripts/common/mf-application.js
@@ -149,18 +149,6 @@
return mw.config.get( 'wgScriptPath', '' ) + '/api.php';
}
- // FIXME: Kill the need for this horrible function by giving me a nicer
API
- function getPageArrayFromApiResponse( response ) {
- var key, results = [], pages = response.query.pages;
-
- for ( key in pages ) {
- if ( pages.hasOwnProperty( key ) ) {
- results.push( pages[ key ] );
- }
- }
- return results;
- }
-
function isLoggedIn() {
return mw.config.get( 'wgUserName' ) ? true : false;
}
@@ -214,7 +202,6 @@
jQuery: typeof jQuery !== 'undefined' ? jQuery : false,
getApiUrl: getApiUrl,
getOrigin: getOrigin,
- getPageArrayFromApiResponse: getPageArrayFromApiResponse,
getSessionId: getSessionId,
isLoggedIn: isLoggedIn,
log: log,
--
To view, visit https://gerrit.wikimedia.org/r/66017
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ba5ce48d1debc7956a4f6253a568ee1059aa4a9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits