Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/66085
Change subject: Disable Squiz.WhiteSpace.ObjectOperatorSpacing ...................................................................... Disable Squiz.WhiteSpace.ObjectOperatorSpacing Change-Id: I1b963b6e17c487019affc92878125ffeb04a95b2 --- M MediaWiki/ruleset.xml 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/codesniffer refs/changes/85/66085/1 diff --git a/MediaWiki/ruleset.xml b/MediaWiki/ruleset.xml index ff21bdd..ad1f88d 100644 --- a/MediaWiki/ruleset.xml +++ b/MediaWiki/ruleset.xml @@ -74,7 +74,13 @@ <rule ref="Squiz.WhiteSpace.LanguageConstructSpacing" /> <rule ref="Squiz.WhiteSpace.LogicalOperatorSpacing" /> <!-- <rule ref="Squiz.WhiteSpace.MemberVarSpacing" /> --> - <rule ref="Squiz.WhiteSpace.ObjectOperatorSpacing" /> + <!-- + `$foo -> bar()` is bad. But we do allow: + $foo + ->bar() + ->quux(); + <rule ref="Squiz.WhiteSpace.ObjectOperatorSpacing" /> + --> <rule ref="Squiz.WhiteSpace.OperatorSpacing" /> <rule ref="Squiz.WhiteSpace.ScopeClosingBrace" /> <rule ref="Squiz.WhiteSpace.ScopeKeywordSpacing" /> -- To view, visit https://gerrit.wikimedia.org/r/66085 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1b963b6e17c487019affc92878125ffeb04a95b2 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/tools/codesniffer Gerrit-Branch: master Gerrit-Owner: Krinkle <krinklem...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits