Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/66964
Change subject: Disable Generic.Formatting.SpaceAfterCast
......................................................................
Disable Generic.Formatting.SpaceAfterCast
This was enabled without sufficient discussion. Let's not
use phpcs to enforce this. Instead there's enough other
rule violations to worry about. Once our code base actually
has this consistently and agreed upon in coding style, then
we can enable it here to enforce it for newly committed code.
Bug: 48450
Change-Id: Ied10f203af5dcff45893bb0246cb6a0469728cb3
---
M MediaWiki/ruleset.xml
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/codesniffer
refs/changes/64/66964/1
diff --git a/MediaWiki/ruleset.xml b/MediaWiki/ruleset.xml
index ad1f88d..e8b4441 100644
--- a/MediaWiki/ruleset.xml
+++ b/MediaWiki/ruleset.xml
@@ -33,7 +33,10 @@
<rule
ref="Generic.Formatting.MultipleStatementAlignment.NotSameWarning">
<severity>0</severity>
</rule>
- <rule ref="Generic.Formatting.SpaceAfterCast" />
+ <!--
+ Community is undecided about (type) $cast vs. (type)$cast (bug
48450).
+ <rule ref="Generic.Formatting.SpaceAfterCast" />
+ -->
<rule ref="Generic.Functions.CallTimePassByReference" />
<rule ref="Generic.Functions.FunctionCallArgumentSpacing" />
<rule
ref="Generic.Functions.FunctionCallArgumentSpacing.TooMuchSpaceAfterComma">
--
To view, visit https://gerrit.wikimedia.org/r/66964
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied10f203af5dcff45893bb0246cb6a0469728cb3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/codesniffer
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
