Inez has uploaded a new change for review.
https://gerrit.wikimedia.org/r/67152
Change subject: ve.dm.Converter: Fix too-much-ascending bug in Converter.
......................................................................
ve.dm.Converter: Fix too-much-ascending bug in Converter.
Change-Id: I748003d316614717c8eaf58dcf5735246951532a
---
M modules/ve/dm/ve.dm.Converter.js
1 file changed, 0 insertions(+), 11 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/52/67152/1
diff --git a/modules/ve/dm/ve.dm.Converter.js b/modules/ve/dm/ve.dm.Converter.js
index b365374..228e35e 100644
--- a/modules/ve/dm/ve.dm.Converter.js
+++ b/modules/ve/dm/ve.dm.Converter.js
@@ -1263,17 +1263,6 @@
);
}
}
-
- // In case of nodes that handles own
children ascend to parent node.
- // It looks like the solution would be
to avoid descending first ( so ascending
- // wouldn't be needed ) but note that
then code above for handling white spaces
- // wouldn't execute correctly.
- if (
- ve.dm.nodeFactory.lookup(
data[i].type ) &&
-
ve.dm.nodeFactory.doesNodeHandleOwnChildren( data[i].type )
- ) {
- domElement = parentDomElement;
- }
}
if ( ve.isArray( dataElementOrSlice ) ) {
--
To view, visit https://gerrit.wikimedia.org/r/67152
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I748003d316614717c8eaf58dcf5735246951532a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Inez <i...@wikia-inc.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
