Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/67164
Change subject: Beta: Reinstate refresh button on nearby
......................................................................
Beta: Reinstate refresh button on nearby
Change-Id: I1c62dd73e9cd2d8a1c1cda9a344a6b22d5f714d8
---
M javascripts/common/mf-navigation.js
M javascripts/specials/nearby.js
2 files changed, 7 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/64/67164/1
diff --git a/javascripts/common/mf-navigation.js
b/javascripts/common/mf-navigation.js
index ffaf7fe..4da8d70 100644
--- a/javascripts/common/mf-navigation.js
+++ b/javascripts/common/mf-navigation.js
@@ -6,10 +6,6 @@
mfePrefix = M.prefix,
inBeta = mw.config.get( 'wgMFMode' ) === 'beta';
- function getPageMenu() {
- return $( '#mw-mf-menu-page' );
- }
-
function openNavigation() {
$( 'body' ).addClass( 'navigation-enabled' );
}
@@ -72,7 +68,6 @@
};
return {
- getPageMenu: getPageMenu,
getMenu: menu
};
}( jQuery ));
diff --git a/javascripts/specials/nearby.js b/javascripts/specials/nearby.js
index 3233584..78d1d37 100644
--- a/javascripts/specials/nearby.js
+++ b/javascripts/specials/nearby.js
@@ -37,6 +37,7 @@
var supported = M.supportsGeoLocation(),
nav = M.require( 'navigation' ),
View = M.require( 'view' ),
+ $userBtn = $( '#user-button' ),
errorMessages = {
empty: {
heading: mw.msg(
'mobile-frontend-nearby-noresults' ),
@@ -244,7 +245,12 @@
overlay.renderError( 'incompatible' );
}
- menu = $( '<li>' ).appendTo( nav.getPageMenu() );
+ if ( $userBtn.length ) {
+ $( '<div id="mw-mf-menu-page">' ).insertAfter( $userBtn );
+ $userBtn.remove();
+ }
+
+ menu = $( '<li>' ).appendTo( '#mw-mf-menu-page' );
btn = $( '<button class="refresh">refresh</button></li>' ).on( 'click',
refresh ).appendTo( menu );
} );
--
To view, visit https://gerrit.wikimedia.org/r/67164
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1c62dd73e9cd2d8a1c1cda9a344a6b22d5f714d8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
