Daniel Werner has uploaded a new change for review.
https://gerrit.wikimedia.org/r/67304
Change subject: Display site-link group specific heading per SiteLinksEditTool
......................................................................
Display site-link group specific heading per SiteLinksEditTool
Change-Id: I2bd6578b4e17096d447769df4470aebd4af110f9
---
M lib/resources/templates.php
M repo/includes/ItemView.php
M repo/resources/wikibase.ui.entityViewInit.js
3 files changed, 10 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/04/67304/1
diff --git a/lib/resources/templates.php b/lib/resources/templates.php
index 2d8b8cf..795fefa 100644
--- a/lib/resources/templates.php
+++ b/lib/resources/templates.php
@@ -239,7 +239,7 @@
$templates['wb-sitelinks-table'] =
<<<HTML
-<table class="wb-sitelinks">
+<table class="wb-sitelinks" data-wb-sitelinks-group="$4">
<colgroup>
<col class="wb-sitelinks-sitename" />
<col class="wb-sitelinks-siteid" />
diff --git a/repo/includes/ItemView.php b/repo/includes/ItemView.php
index 336528b..b1c734f 100644
--- a/repo/includes/ItemView.php
+++ b/repo/includes/ItemView.php
@@ -145,7 +145,7 @@
$this->getHtmlForEditSection( $item, $lang, $editLink,
'td', 'add', !$isFull )
);
- return $html . wfTemplate( 'wb-sitelinks-table', $thead,
$tbody, $tfoot );
+ return $html . wfTemplate( 'wb-sitelinks-table', $thead,
$tbody, $tfoot, $group );
}
}
diff --git a/repo/resources/wikibase.ui.entityViewInit.js
b/repo/resources/wikibase.ui.entityViewInit.js
index b570cfc..53be11a 100644
--- a/repo/resources/wikibase.ui.entityViewInit.js
+++ b/repo/resources/wikibase.ui.entityViewInit.js
@@ -126,9 +126,15 @@
// removing site links heading to rebuild it with value
counter
$( 'table.wb-sitelinks' ).each( function() {
+ var group = $( this ).data(
'wb-sitelinks-group' );
+
+ // add site links section heading:
$( this ).before(
- mw.template( 'wb-section-heading',
mw.msg( 'wikibase-sitelinks' ), 'sitelinks' )
- .append(
+ mw.template(
+ 'wb-section-heading',
+ mw.msg( 'wikibase-sitelinks-' +
group ),
+ 'sitelinks'
+ ).append(
$( '<span/>' )
.attr( 'id', 'wb-item-' +
mw.config.get('wbEntityId') + '-sitelinks-counter' )
.addClass(
'wb-ui-propertyedittool-counter' )
--
To view, visit https://gerrit.wikimedia.org/r/67304
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2bd6578b4e17096d447769df4470aebd4af110f9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Daniel Werner <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
