Aaron Schulz has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/67316


Change subject: Fixed long memcached keys.
......................................................................

Fixed long memcached keys.

Change-Id: I517f3923414f223cb103d7e6b11b1a5b4a7a2bca
---
M tag/PageTranslationHooks.php
M tag/TranslateMoveJob.php
2 files changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/16/67316/1

diff --git a/tag/PageTranslationHooks.php b/tag/PageTranslationHooks.php
index 746fdc8..c5e0be6 100644
--- a/tag/PageTranslationHooks.php
+++ b/tag/PageTranslationHooks.php
@@ -764,7 +764,7 @@
                }
 
                $cache = wfGetCache( CACHE_ANYTHING );
-               $key = wfMemcKey( 'pt-lock', $title->getPrefixedText() );
+               $key = wfMemcKey( 'pt-lock', sha1( $title->getPrefixedText() ) 
);
                // At least memcached mangles true to "1"
                if ( $cache->get( $key ) == true ) {
                        $result = array( 'pt-locked-page' );
diff --git a/tag/TranslateMoveJob.php b/tag/TranslateMoveJob.php
index 55d027c..bc68584 100644
--- a/tag/TranslateMoveJob.php
+++ b/tag/TranslateMoveJob.php
@@ -161,14 +161,14 @@
 
        public function lock() {
                $cache = wfGetCache( CACHE_ANYTHING );
-               $cache->set( wfMemcKey( 'pt-lock', 
$this->title->getPrefixedText() ), true );
-               $cache->set( wfMemcKey( 'pt-lock', 
$this->getTarget()->getPrefixedText() ), true );
+               $cache->set( wfMemcKey( 'pt-lock', sha1( 
$this->title->getPrefixedText() ) ), true );
+               $cache->set( wfMemcKey( 'pt-lock', sha1( 
$this->getTarget()->getPrefixedText() ) ), true );
        }
 
        public function unlock() {
                $cache = wfGetCache( CACHE_ANYTHING );
-               $cache->delete( wfMemcKey( 'pt-lock', 
$this->title->getPrefixedText() ) );
-               $cache->delete( wfMemcKey( 'pt-lock', 
$this->getTarget()->getPrefixedText() ) );
+               $cache->delete( wfMemcKey( 'pt-lock', sha1( 
$this->title->getPrefixedText() ) ) );
+               $cache->delete( wfMemcKey( 'pt-lock', sha1( 
$this->getTarget()->getPrefixedText() ) ) );
        }
 
        /**

-- 
To view, visit https://gerrit.wikimedia.org/r/67316
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I517f3923414f223cb103d7e6b11b1a5b4a7a2bca
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to