Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/67356


Change subject: Alpha: Make search results lazy load pages
......................................................................

Alpha: Make search results lazy load pages

Change-Id: I256d8f88912f653cfde168d1d8822456db21df00
---
M includes/Resources.php
M javascripts/common/history-alpha.js
A javascripts/modules/lazyload.js
3 files changed, 19 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/56/67356/1

diff --git a/includes/Resources.php b/includes/Resources.php
index 39028b9..bab9a98 100644
--- a/includes/Resources.php
+++ b/includes/Resources.php
@@ -355,6 +355,7 @@
                        'javascripts/common/history-alpha.js',
                        'javascripts/modules/mf-tables.js',
                        'javascripts/modules/mf-translator.js',
+                       'javascripts/modules/lazyload.js',
                ),
        ),
 
diff --git a/javascripts/common/history-alpha.js 
b/javascripts/common/history-alpha.js
index 054d06b..94e6f5b 100644
--- a/javascripts/common/history-alpha.js
+++ b/javascripts/common/history-alpha.js
@@ -86,7 +86,6 @@
                hijackLinks( $( '#content_0' ), useFuzzyLinkHijacking );
 
                // Bind events
-               searchOverlay.on( 'write-results', hijackLinksOverlay );
                M.on( 'section-rendered', function( $container ) {
                        hijackLinks( $container, useFuzzyLinkHijacking );
                } ).on( 'page-loaded', function( page ) {
@@ -104,10 +103,13 @@
 
                // initial history state does not contain title
                History.replaceState( null, mw.config.get( 'wgTitle' ) );
+               return {
+                       hijackLinks: hijackLinks
+               };
        }
 
        if ( History.enabled ) {
-               init();
+               $.extend( M.history, init() );
        }
 
        $.extend( M.history, {
diff --git a/javascripts/modules/lazyload.js b/javascripts/modules/lazyload.js
new file mode 100644
index 0000000..fccd60a
--- /dev/null
+++ b/javascripts/modules/lazyload.js
@@ -0,0 +1,14 @@
+( function( M ) {
+
+var searchOverlay = M.require( 'search' ).overlay,
+       history = M.history;
+
+searchOverlay.on( 'write-results', function( overlay ) {
+       var $results = overlay.$( 'ul' );
+       history.hijackLinks( $results );
+       $results.find( 'a' ).on( 'click', function() {
+               overlay.hide();
+       } );
+} );
+
+}( mw.mobileFrontend ));

-- 
To view, visit https://gerrit.wikimedia.org/r/67356
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I256d8f88912f653cfde168d1d8822456db21df00
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to