Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/67385
Change subject: Get rid of SiteLink::newFromText usage in SiteLinkTable
......................................................................
Get rid of SiteLink::newFromText usage in SiteLinkTable
Change-Id: I841619af33088424076af1b7f3a3d3d00dc50de9
---
M lib/includes/store/sql/SiteLinkTable.php
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/85/67385/1
diff --git a/lib/includes/store/sql/SiteLinkTable.php
b/lib/includes/store/sql/SiteLinkTable.php
index 0b883c9..e3e38ed 100644
--- a/lib/includes/store/sql/SiteLinkTable.php
+++ b/lib/includes/store/sql/SiteLinkTable.php
@@ -407,6 +407,7 @@
* @throws \MWException
*
* @return SiteLink[]
+ * TODO: return SimpleSiteLink[] instead
*/
public function getSiteLinksForItem( EntityId $entityId ) {
if ( $entityId->getEntityType() !== Item::ENTITY_TYPE ) {
@@ -431,7 +432,10 @@
$siteLinks = array();
foreach( $rows as $row ) {
- $siteLinks[] = SiteLink::newFromText(
$row->ips_site_id, $row->ips_site_page );
+ $siteLinks[] = new SiteLink(
+ \Sites::singleton()->getSite( $row->ips_site_id
),
+ $row->ips_site_page
+ );
}
$this->releaseConnection( $dbr );
--
To view, visit https://gerrit.wikimedia.org/r/67385
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I841619af33088424076af1b7f3a3d3d00dc50de9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
