Tobias Gritschacher has submitted this change and it was merged.
Change subject: Remove dead code in SiteLink::newFromText
......................................................................
Remove dead code in SiteLink::newFromText
Change-Id: Ida6fd8369247cce7e893825731a17ffc65e1d6b5
---
M DataModel/DataModel/SiteLink.php
1 file changed, 0 insertions(+), 10 deletions(-)
Approvals:
Tobias Gritschacher: Looks good to me, approved
jenkins-bot: Verified
diff --git a/DataModel/DataModel/SiteLink.php b/DataModel/DataModel/SiteLink.php
index 5797462..7cfc36e 100644
--- a/DataModel/DataModel/SiteLink.php
+++ b/DataModel/DataModel/SiteLink.php
@@ -65,16 +65,6 @@
$site->setGlobalId( $globalSiteId );
}
- if ( $normalize ) {
- $normalized = $site->normalizePageName( $page );
-
- if ( $normalized === false ) {
- throw new MWException( "failed to normalize
title: $page" );
- }
-
- $page = $normalized;
- }
-
return new SiteLink( $site, $page );
}
--
To view, visit https://gerrit.wikimedia.org/r/67364
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ida6fd8369247cce7e893825731a17ffc65e1d6b5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
