Cmcmahon has submitted this change and it was merged. Change subject: Make sure the link is there before trying to click it ......................................................................
Make sure the link is there before trying to click it Fixes: Element is not currently visible and so may not be interacted with (Selenium::WebDriver::Error::ElementNotVisibleError) Change-Id: I478adec5f48d3aa484e00573ca22302fa6909602 --- M features/step_definitions/pdf_steps.rb 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Cmcmahon: Verified; Looks good to me, approved jenkins-bot: Verified diff --git a/features/step_definitions/pdf_steps.rb b/features/step_definitions/pdf_steps.rb index ac941f2..54bdcdb 100644 --- a/features/step_definitions/pdf_steps.rb +++ b/features/step_definitions/pdf_steps.rb @@ -2,7 +2,7 @@ on(RandomPage).download_as_pdf_element.should exist end When(/^I click on Download as PDF$/) do - on(RandomPage).download_as_pdf + on(RandomPage).download_as_pdf_element.when_present.click end Then(/^Download the file link should be present$/) do on(RandomPage).download_the_file_element.when_present(30).should exist -- To view, visit https://gerrit.wikimedia.org/r/67461 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I478adec5f48d3aa484e00573ca22302fa6909602 Gerrit-PatchSet: 1 Gerrit-Project: qa/browsertests Gerrit-Branch: master Gerrit-Owner: Zfilipin <[email protected]> Gerrit-Reviewer: Cmcmahon <[email protected]> Gerrit-Reviewer: Rachel99 <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
