Daniel Werner has submitted this change and it was merged.
Change subject: Remove misplaced test method that is now testing deprecated code
......................................................................
Remove misplaced test method that is now testing deprecated code
Change-Id: Ia5ce391d2625be79be3a8b0f7a4dda29e426e1d7
---
M DataModel/tests/phpunit/Entity/ItemNewEmptyTest.php
1 file changed, 0 insertions(+), 35 deletions(-)
Approvals:
Daniel Werner: Looks good to me, approved
jenkins-bot: Verified
diff --git a/DataModel/tests/phpunit/Entity/ItemNewEmptyTest.php
b/DataModel/tests/phpunit/Entity/ItemNewEmptyTest.php
index 237c329..11a9124 100644
--- a/DataModel/tests/phpunit/Entity/ItemNewEmptyTest.php
+++ b/DataModel/tests/phpunit/Entity/ItemNewEmptyTest.php
@@ -135,39 +135,4 @@
);
}
- /**
- * Tests @see Item::addSiteLink
- * Tests @see Item::removeSiteLink
- * Tests @see Item::getSiteLinks
- */
- public function testAddRemoveSiteLink() {
- $arr = array(
- SiteLink::newFromText( 'nnwiki', 'Norge' ),
- SiteLink::newFromText( 'enwiki', 'English' ),
- );
-
- /**
- * @var SiteLink $link
- */
- foreach ( $arr as $link ) {
- $this->item->addSiteLink( $link );
- }
-
- $this->assertEquals(
- $arr,
- $this->item->getSiteLinks(),
- 'Testing if getSiteLinks reconstructs the whole
structure after it is built with addSiteLink'
- );
-
- foreach ( $arr as $link ) {
- $this->item->removeSiteLink(
$link->getSite()->getGlobalId() );
- }
-
- $this->assertCount(
- 0,
- $this->item->getSiteLinks(),
- 'Testing if removeSiteLink decrements the whole
structure to zero after it is built with addSiteLink'
- );
- }
-
}
--
To view, visit https://gerrit.wikimedia.org/r/67383
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia5ce391d2625be79be3a8b0f7a4dda29e426e1d7
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Daniel Werner <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
