Ryan Lane has submitted this change and it was merged.

Change subject: Use subprocess.call for restarting parsoid
......................................................................


Use subprocess.call for restarting parsoid

Temporary hack to restart parsoid for now. Parsoid doesn't fork
properly, so using subprocess.call with shell=True allows parsoid
to restart on deploy.

Change-Id: Id6a7f1ced484f85e227c9fb1b78884f38994af97
---
M modules/deployment/files/modules/parsoid.py
1 file changed, 3 insertions(+), 4 deletions(-)

Approvals:
  Ryan Lane: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/deployment/files/modules/parsoid.py 
b/modules/deployment/files/modules/parsoid.py
index 8189aed..87a6a33 100644
--- a/modules/deployment/files/modules/parsoid.py
+++ b/modules/deployment/files/modules/parsoid.py
@@ -3,6 +3,7 @@
 '''
 
 import os
+import subprocess
 
 
 def config_symlink(repo):
@@ -32,7 +33,5 @@
     '''
     restart the parsoid service
     '''
-    if __salt__['service.restart']('parsoid'):
-        return 0
-    else:
-        return 1
+    ret = subprocess.call("/etc/init.d/parsoid restart", shell=True)
+    return ret

-- 
To view, visit https://gerrit.wikimedia.org/r/67494
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id6a7f1ced484f85e227c9fb1b78884f38994af97
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ryan Lane <rl...@wikimedia.org>
Gerrit-Reviewer: Ryan Lane <rl...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to