Mwalker has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/67518


Change subject: Ack! Function Arguments in Wrong Order
......................................................................

Ack! Function Arguments in Wrong Order

This changes from get by type to get by id -- which is what we want :)

This is also why I want to change something; I just don't know what...
This is too error prone!

Change-Id: Id574fad0f00147b6a8a2653c871c799367be858b
---
M SmashPig/PaymentProviders/Adyen/Jobs/ProcessCaptureRequestJob.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/PaymentsListeners 
refs/changes/18/67518/1

diff --git a/SmashPig/PaymentProviders/Adyen/Jobs/ProcessCaptureRequestJob.php 
b/SmashPig/PaymentProviders/Adyen/Jobs/ProcessCaptureRequestJob.php
index 76b4d0a..99610ce 100644
--- a/SmashPig/PaymentProviders/Adyen/Jobs/ProcessCaptureRequestJob.php
+++ b/SmashPig/PaymentProviders/Adyen/Jobs/ProcessCaptureRequestJob.php
@@ -46,7 +46,7 @@
                // processed this particular transaction before
                Logger::debug( 'Attempting to locate associated message in 
pending queue' );
                $pendingQueue = Configuration::getDefaultConfig()->obj( 
'data-store/pending' );
-               $queueMessage = $pendingQueue->queueGetObject( 
$this->correlationId );
+               $queueMessage = $pendingQueue->queueGetObject( null, 
$this->correlationId );
 
                if ( $queueMessage && ( $queueMessage instanceof 
DonationInterfaceMessage ) ) {
                        Logger::debug( 'A valid message was obtained from the 
pending queue' );

-- 
To view, visit https://gerrit.wikimedia.org/r/67518
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id574fad0f00147b6a8a2653c871c799367be858b
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/PaymentsListeners
Gerrit-Branch: master
Gerrit-Owner: Mwalker <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to