Demon has submitted this change and it was merged.
Change subject: Short-circuit user rights checking code.
......................................................................
Short-circuit user rights checking code.
Change-Id: I578e580d610dd080dfc72ab8ea332542d0ac1034
---
M backend/FlaggedRevs.hooks.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Demon: Verified; Looks good to me, approved
diff --git a/backend/FlaggedRevs.hooks.php b/backend/FlaggedRevs.hooks.php
index 6977b42..b22e50c 100644
--- a/backend/FlaggedRevs.hooks.php
+++ b/backend/FlaggedRevs.hooks.php
@@ -934,7 +934,7 @@
public static function setSessionKey( User $user ) {
global $wgRequest;
- if ( $user->isAllowed( 'review' ) ) {
+ if ( $user->isLoggedIn() && $user->isAllowed( 'review' ) ) {
$key = $wgRequest->getSessionData( 'wsFlaggedRevsKey' );
if ( $key === null ) { // should catch login
$key = MWCryptRand::generateHex( 32 );
--
To view, visit https://gerrit.wikimedia.org/r/67194
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I578e580d610dd080dfc72ab8ea332542d0ac1034
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FlaggedRevs
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Demon <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
