jenkins-bot has submitted this change and it was merged.

Change subject: More informative warning for invalid enum value
......................................................................


More informative warning for invalid enum value

It now says what property has a bad value.

Change-Id: I41317544988f5df08c0e614be94e77738b1d9f59
---
M modules/ext.eventLogging.core.js
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Ori.livneh: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ext.eventLogging.core.js b/modules/ext.eventLogging.core.js
index 56a3e86..fe18667 100644
--- a/modules/ext.eventLogging.core.js
+++ b/modules/ext.eventLogging.core.js
@@ -175,7 +175,8 @@
                                }
 
                                if ( desc[ 'enum' ] && $.inArray( val, desc[ 
'enum' ] ) === -1 ) {
-                                       throw new ValidationError( 'Value "' + 
val + '" not in enum ' + $.toJSON( desc[ 'enum' ] ) );
+                                       throw new ValidationError( 'Value "' + 
val + '" for property: ' + prop +
+                                               ' not in enum ' + $.toJSON( 
desc[ 'enum' ] ) );
                                }
                        } );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/67567
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I41317544988f5df08c0e614be94e77738b1d9f59
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: master
Gerrit-Owner: Spage <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to