Mwjames has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/67590


Change subject: SMW\MessageFormatter dependency injection
......................................................................

SMW\MessageFormatter dependency injection

Shifting towards better testability of classes also means to use
proper dependency injection, SMW\MessageFormatter is now a
require dependency [1]

[1] https://gerrit.wikimedia.org/r/#/c/58040

Change-Id: Icb01642cc7af85c421047d4986ae8b9266667641
---
M SIO_SubobjectAlias.php
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticInternalObjects 
refs/changes/90/67590/1

diff --git a/SIO_SubobjectAlias.php b/SIO_SubobjectAlias.php
index 0865ff1..d51d7c1 100644
--- a/SIO_SubobjectAlias.php
+++ b/SIO_SubobjectAlias.php
@@ -59,7 +59,8 @@
                        // SMW 1.9+
                        $subobjectFunction = new SMW\SubobjectParserFunction(
                                new SMW\ParserData( $parser->getTitle(), 
$parser->getOutput() ),
-                               new SMW\Subobject( $parser->getTitle() )
+                               new SMW\Subobject( $parser->getTitle() ),
+                               new SMW\MessageFormatter( 
$parser->getTargetLanguage() )
                        );
                        return $subobjectFunction->parse( new 
SMW\ParserParameterFormatter( $subobjectArgs ) );
                } else {
@@ -82,7 +83,8 @@
                        // SMW 1.9+
                        $recurringEventFunction = new 
SMW\RecurringEventsParserFunction(
                                new SMW\ParserData( $parser->getTitle(), 
$parser->getOutput() ),
-                               new SMW\Subobject( $parser->getTitle() )
+                               new SMW\Subobject( $parser->getTitle() ),
+                               new SMW\MessageFormatter( 
$parser->getTargetLanguage() )
                        );
                        return $recurringEventFunction->parse( new 
SMW\ParserParameterFormatter( $params ) );
                } else {

-- 
To view, visit https://gerrit.wikimedia.org/r/67590
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb01642cc7af85c421047d4986ae8b9266667641
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticInternalObjects
Gerrit-Branch: master
Gerrit-Owner: Mwjames <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to