Bharaththiruveedula has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/67615


Change subject: Added 'Developers' link to footer link
......................................................................

Added 'Developers' link to footer link

Change-Id: I2067e6a6f90dd1818b8b6d8edd7e2e89bc4fbfca
---
M includes/Skin.php
M includes/SkinTemplate.php
M languages/messages/MessagesEn.php
3 files changed, 23 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/15/67615/1

diff --git a/includes/Skin.php b/includes/Skin.php
index 53003c6..328b8eb 100644
--- a/includes/Skin.php
+++ b/includes/Skin.php
@@ -959,12 +959,18 @@
                        // Otherwise, we display the link for the user, 
described in their
                        // language (which may or may not be the same as the 
default language),
                        // but we make the link target be the one site-wide 
page.
+                       $link = $this->msg( $page 
)->inContentLanguage()->text();
+                       $linkText = $this->msg( $desc )->escaped();
                        $title = Title::newFromText( $this->msg( $page 
)->inContentLanguage()->text() );
-
-                       return Linker::linkKnown(
-                               $title,
-                               $this->msg( $desc )->escaped()
-                       );
+                       if ( preg_match( '/^(?i:'.wfUrlProtocols() .')/', 
$link) ) {
+                          return Linker::makeExternalLink( $link, $linkText, 
false, '', array(), $this->getRelevantTitle() );   
+                       }
+                       else {
+                           return Linker::linkKnown(
+                                   $title,
+                                   $this->msg( $desc )->escaped()
+                           );
+                       }
                }
        }
 
@@ -992,6 +998,14 @@
                return $this->footerLink( 'disclaimers', 'disclaimerpage' );
        }
 
+    /**
+     * Gets the link to the How to become Mediawiki Hacker's page.
+     * @return String HTML
+     */
+    function developerLink() {
+        return $this->footerLink( 'developer', 'developerpage' );
+    }
+
        /**
         * Return URL options for the 'edit page' link.
         * This may include an 'oldid' specifier, if the current page view is 
such.
diff --git a/includes/SkinTemplate.php b/includes/SkinTemplate.php
index fa90954..891cbd0 100644
--- a/includes/SkinTemplate.php
+++ b/includes/SkinTemplate.php
@@ -394,6 +394,7 @@
                $tpl->set( 'disclaimer', $this->disclaimerLink() );
                $tpl->set( 'privacy', $this->privacyLink() );
                $tpl->set( 'about', $this->aboutLink() );
+               $tpl->set( 'developer', $this->developerLink() );
 
                $tpl->set( 'footerlinks', array(
                        'info' => array(
@@ -407,6 +408,7 @@
                                'privacy',
                                'about',
                                'disclaimer',
+                               'developer',
                        ),
                ) );
 
diff --git a/languages/messages/MessagesEn.php 
b/languages/messages/MessagesEn.php
index c539dba..b557fa0d5 100644
--- a/languages/messages/MessagesEn.php
+++ b/languages/messages/MessagesEn.php
@@ -905,6 +905,8 @@
 'copyrightpage'        => '{{ns:project}}:Copyrights',
 'currentevents'        => 'Current events',
 'currentevents-url'    => 'Project:Current events',
+'developer'            => 'Developer',
+'developerpage'        => 
'https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker',
 'disclaimers'          => 'Disclaimers',
 'disclaimerpage'       => 'Project:General disclaimer',
 'edithelp'             => 'Editing help',

-- 
To view, visit https://gerrit.wikimedia.org/r/67615
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2067e6a6f90dd1818b8b6d8edd7e2e89bc4fbfca
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bharaththiruveedula <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to