GWicke has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/67646


Change subject: Don't follow redirects any more
......................................................................

Don't follow redirects any more

For some reason the redirect logic in the APIRequest was still active, which
resulted in a page source retrieval loop in [[en:Sudanese_Americans]] which
contains a redirect to itself.

Change-Id: I5c3ba98522f5cc51ae1282c206998740c7c24592
---
M js/lib/mediawiki.ApiRequest.js
1 file changed, 0 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid 
refs/changes/46/67646/1

diff --git a/js/lib/mediawiki.ApiRequest.js b/js/lib/mediawiki.ApiRequest.js
index 7e8c1b3..b600952 100644
--- a/js/lib/mediawiki.ApiRequest.js
+++ b/js/lib/mediawiki.ApiRequest.js
@@ -302,25 +302,6 @@
                }
        }
 
-       // check for #REDIRECT
-       var redirMatch = src.match( /[\r\n\s]*#\s*redirect\s*\[\[([^\]]+)\]\]/i 
);
-       if ( redirMatch ) {
-               title = redirMatch[1];
-               var url = this.env.conf.parsoid.apiURI + '?' +
-                               qs.stringify( {
-                                       format: 'json',
-                                       action: 'query',
-                                       prop: 'revisions',
-                                       rvprop: PARSOID_RVPROP,
-                                       titles: title
-                               } );
-               
//'?format=json&action=query&prop=revisions&rvprop=content&titles=' + title;
-               this.requestOptions.url = url;
-               this.title = title;
-               this.request( this.requestOptions, this._requestCB.bind(this) );
-               return;
-       }
-
        //console.warn( 'Page ' + this.title + ': got ' + 
JSON.stringify(metadata) );
        this.env.tp( 'Retrieved ' + this.title, metadata );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/67646
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5c3ba98522f5cc51ae1282c206998740c7c24592
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: GWicke <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to