jenkins-bot has submitted this change and it was merged.
Change subject: Clone node data when dumping DOM for debugging purposes.
......................................................................
Clone node data when dumping DOM for debugging purposes.
* Without the clone, the original DOM has its data object modified
which changes semantics.
Change-Id: I2305a07dc21a9d4c46ff8bf1ad2251aa6ced5134
---
M js/lib/mediawiki.DOMPostProcessor.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
GWicke: Looks good to me, approved
jenkins-bot: Verified
diff --git a/js/lib/mediawiki.DOMPostProcessor.js
b/js/lib/mediawiki.DOMPostProcessor.js
index df8e2ec..f3ab593 100644
--- a/js/lib/mediawiki.DOMPostProcessor.js
+++ b/js/lib/mediawiki.DOMPostProcessor.js
@@ -2315,7 +2315,7 @@
function cloneData(node, clone) {
var d = node.data;
if (d && d.constructor === Object &&
(Object.keys(d.parsoid).length > 0)) {
- clone.data = d;
+ clone.data = Util.clone(d);
saveDataParsoid( clone );
}
--
To view, visit https://gerrit.wikimedia.org/r/67843
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2305a07dc21a9d4c46ff8bf1ad2251aa6ced5134
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry <[email protected]>
Gerrit-Reviewer: GWicke <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
