Catrope has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/68017


Change subject: Use the correct $$ in the meta dialog
......................................................................

Use the correct $$ in the meta dialog

Change-Id: Id23228c67eb4e50b3912b6148374e459b0f59b34
---
M modules/ve/ui/dialogs/ve.ui.MWMetaDialog.js
1 file changed, 8 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/17/68017/1

diff --git a/modules/ve/ui/dialogs/ve.ui.MWMetaDialog.js 
b/modules/ve/ui/dialogs/ve.ui.MWMetaDialog.js
index c9f6b2f..3a16e9f 100644
--- a/modules/ve/ui/dialogs/ve.ui.MWMetaDialog.js
+++ b/modules/ve/ui/dialogs/ve.ui.MWMetaDialog.js
@@ -104,24 +104,24 @@
        this.pages.languages.$.append( this.languagesFieldset.$ );
 
        this.languagesFieldset.$
-               .append( this.$$( '<span>' ).text( ve.msg( 
'visualeditor-dialog-meta-languages-readonlynote' ) ) );
+               .append( this.frame.$$( '<span>' ).text( ve.msg( 
'visualeditor-dialog-meta-languages-readonlynote' ) ) );
 
        languagePromise = this.getAllLanguageItems();
        languagePromise.done( ve.bind( function ( languages ) {
-               var i, $languagesTable = this.$$( '<table>' ), languageslength 
= languages.length;
+               var i, $languagesTable = this.frame.$$( '<table>' ), 
languageslength = languages.length;
 
                $languagesTable
                        .addClass( 've-ui-dialog-meta-languages-table' )
-                       .append( this.$$( '<tr>' )
-                               .append( this.$$( '<th>' ).append( ve.msg( 
'visualeditor-dialog-meta-languages-code-label' ) ) )
-                               .append( this.$$( '<th>' ).append( ve.msg( 
'visualeditor-dialog-meta-languages-link-label' ) ) )
+                       .append( this.frame.$$( '<tr>' )
+                               .append( this.frame.$$( '<th>' ).append( 
ve.msg( 'visualeditor-dialog-meta-languages-code-label' ) ) )
+                               .append( this.frame.$$( '<th>' ).append( 
ve.msg( 'visualeditor-dialog-meta-languages-link-label' ) ) )
                );
 
                for ( i = 0; i < languageslength; i++ ) {
                        $languagesTable
-                               .append( $( '<tr>' )
-                                       .append( $( '<td>' ).append( 
languages[i].lang ) )
-                                       .append( $( '<td>' ).append( 
languages[i].title ) )
+                               .append( this.frame.$$( '<tr>' )
+                                       .append( this.frame.$$( '<td>' 
).append( languages[i].lang ) )
+                                       .append( this.frame.$$( '<td>' 
).append( languages[i].title ) )
                                );
                }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/68017
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id23228c67eb4e50b3912b6148374e459b0f59b34
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to