jenkins-bot has submitted this change and it was merged.
Change subject: Actually send the query parameters in ParsoidCacheRequest
......................................................................
Actually send the query parameters in ParsoidCacheRequest
For GET requests we are responsible for constructing our own URL. This was
missing in ParsoidCacheRequest, which lead to cache requests without the
proper oldid in the query.
Change-Id: Id24f72da59123c64b2ca10b25ffc6e40e2ba9ffa
---
M js/lib/mediawiki.ApiRequest.js
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Subramanya Sastry: Looks good to me, approved
jenkins-bot: Verified
diff --git a/js/lib/mediawiki.ApiRequest.js b/js/lib/mediawiki.ApiRequest.js
index b600952..ebc312b 100644
--- a/js/lib/mediawiki.ApiRequest.js
+++ b/js/lib/mediawiki.ApiRequest.js
@@ -493,7 +493,8 @@
oldid: oldid
};
var url = env.conf.parsoid.parsoidCacheURI +
- env.conf.wiki.iwp + '/' + title.replace(/ /g, '_');
+ env.conf.wiki.iwp + '/' + title.replace(/ /g, '_') +
+ '?' + qs.stringify( apiargs );
console.log(url);
@@ -502,7 +503,6 @@
this.requestOptions = {
// Use GET so that our request is cacheable
method: 'GET',
- form: apiargs, // The API arguments
followRedirect: false,
url: url,
timeout: 16 * 1000, // 16 seconds
--
To view, visit https://gerrit.wikimedia.org/r/68033
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id24f72da59123c64b2ca10b25ffc6e40e2ba9ffa
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: GWicke <[email protected]>
Gerrit-Reviewer: Subramanya Sastry <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
