JGonera has submitted this change and it was merged.
Change subject: Regression: Stop locking viewport on overlays
......................................................................
Regression: Stop locking viewport on overlays
Stop locking the viewport. This has nasty consequences on Android
(super large text) and iPhone (breaks position fixed)
Change-Id: I69e5d1b66b70484a9182e6508246baad33b241c9
---
M javascripts/common/Overlay.js
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
JGonera: Verified; Looks good to me, approved
jenkins-bot: Checked
diff --git a/javascripts/common/Overlay.js b/javascripts/common/Overlay.js
index 21f3df6..60291b7 100644
--- a/javascripts/common/Overlay.js
+++ b/javascripts/common/Overlay.js
@@ -21,7 +21,8 @@
} );
},
show: function() {
- M.lockViewport();
+ // FIXME: prevent zooming within overlays but don't
break the rendering!
+ // M.lockViewport();
if ( this.parent ) {
this.parent.hide();
}
@@ -34,7 +35,8 @@
window.scrollTo( 0, 1 );
},
hide: function() {
- M.unlockViewport();
+ // FIXME: allow zooming outside the overlay again
+ // M.unlockViewport();
this.$el.detach();
if ( !this.parent ) {
$( 'html' ).removeClass( 'overlay' );
--
To view, visit https://gerrit.wikimedia.org/r/68048
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I69e5d1b66b70484a9182e6508246baad33b241c9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: JGonera <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
