jenkins-bot has submitted this change and it was merged.

Change subject: Don't run mw.echo.special.initialize until DOM is ready
......................................................................


Don't run mw.echo.special.initialize until DOM is ready

To fix rare race condition in Safari

Change-Id: I2ae556ff6e44f291e761d2937203a3376f4a3177
---
M modules/special/ext.echo.special.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  EBernhardson (WMF): Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/special/ext.echo.special.js 
b/modules/special/ext.echo.special.js
index 7e15fbe..06018ef 100644
--- a/modules/special/ext.echo.special.js
+++ b/modules/special/ext.echo.special.js
@@ -170,6 +170,6 @@
                }
        };
 
-       mw.echo.special.initialize();
+       $( document ).ready( mw.echo.special.initialize );
 
 } )( jQuery, mediaWiki );

-- 
To view, visit https://gerrit.wikimedia.org/r/68040
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2ae556ff6e44f291e761d2937203a3376f4a3177
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Kaldari <[email protected]>
Gerrit-Reviewer: Bsitu <[email protected]>
Gerrit-Reviewer: EBernhardson (WMF) <[email protected]>
Gerrit-Reviewer: Kaldari <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Matthias Mullie <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to