Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/68117
Change subject: Log page save timing events ...................................................................... Log page save timing events This change adds a call to log PageSaveTiming events <http://meta.wikimedia.org/wiki/Schema:PageSaveTiming> on successful saves. Change-Id: Iccd171d7cde15b0302d1b4c292bcbcc2a4b337ef --- M VisualEditor.php M modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js 2 files changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/17/68117/1 diff --git a/VisualEditor.php b/VisualEditor.php index 7b78884..ecac979 100644 --- a/VisualEditor.php +++ b/VisualEditor.php @@ -65,6 +65,15 @@ $wgVisualEditorEnableSectionEditLinks = false; $wgResourceModules += array( + + // EventLogging schema module + // See <http://meta.wikimedia.org/wiki/Schema:PageSaveTiming> + 'schema.PageSaveTiming' => array( + 'class' => 'ResourceLoaderSchemaModule', + 'schema' => 'PageSaveTiming', + 'revision' => 5557427, + ), + 'rangy' => $wgVisualEditorResourceTemplate + array( 'scripts' => array( 'rangy/rangy-core-1.3.js', @@ -478,6 +487,7 @@ 've/ui/styles/ve.ui.Widget.css', ), 'dependencies' => array( + 'schema.PageSaveTiming', 'jquery', 'rangy', 'unicodejs.wordbreak', diff --git a/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js b/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js index e74710f..17402bd 100644 --- a/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js +++ b/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js @@ -366,6 +366,15 @@ * @param {number} [newid] New revision id, undefined if unchanged */ ve.init.mw.ViewPageTarget.prototype.onSave = function ( html, newid ) { + mw.eventLog.logEvent( 'PageSaveTiming', { + version: 0, + editor: 'visualeditor', + pageId: mw.config.get( 'wgArticleId' ), + pageNs: mw.config.get( 'wgNamespaceNumber' ), + revId: +mw.config.get( 'wgStableRevisionId' ), + timeDiff: this.saveStart ? new Date - this.saveStart : 0 + } ); + if ( !this.pageExists || this.restoring ) { // This is a page creation or restoration, refresh the page this.tearDownBeforeUnloadHandler(); @@ -653,6 +662,7 @@ ve.init.mw.ViewPageTarget.prototype.onSaveDialogSaveButtonClick = function () { var doc = this.surface.getModel().getDocument(), saveOptions = this.getSaveOptions(); + this.saveStart = +new Date; if ( +mw.user.options.get( 'forceeditsummary' ) && saveOptions.summary === '' && -- To view, visit https://gerrit.wikimedia.org/r/68117 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iccd171d7cde15b0302d1b4c292bcbcc2a4b337ef Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Ori.livneh <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
