Trevor Parscal has uploaded a new change for review.
https://gerrit.wikimedia.org/r/68129
Change subject: Category popup fixes
......................................................................
Category popup fixes
Objectives:
* Make category popup show "Category" rather than missing message - this is
more similar to other popups like inspectors, which identify what that thing is
that you are working on
* Fix alignment of icon and label in category popup
Changes:
ve.ui.Widget.css
* Make popup title align properly with the remove button
ve.ui.MWCategoryPopupWidget.js
* Update message key
*.php
* Add new message
Change-Id: Ia8051125bbc9bde47ceb931e1ebf42b2955481ff
---
M VisualEditor.i18n.php
M VisualEditor.php
M modules/ve/ui/styles/ve.ui.Widget.css
M modules/ve/ui/widgets/ve.ui.MWCategoryPopupWidget.js
4 files changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/29/68129/1
diff --git a/VisualEditor.i18n.php b/VisualEditor.i18n.php
index d89b6ef..204eee8 100644
--- a/VisualEditor.i18n.php
+++ b/VisualEditor.i18n.php
@@ -84,6 +84,7 @@
'visualeditor-inspector-remove-tooltip' => 'Remove',
'visualeditor-dialog-meta-categories-section' => 'Categories',
'visualeditor-dialog-meta-categories-data-label' => 'Categories',
+ 'visualeditor-dialog-meta-categories-category' => 'Category',
'visualeditor-dialog-meta-categories-options' => 'Options',
'visualeditor-dialog-meta-categories-input-placeholder' => 'Add a
category',
'visualeditor-dialog-meta-categories-input-newcategorylabel' => 'New
category',
diff --git a/VisualEditor.php b/VisualEditor.php
index 58262ba..edabbbc 100644
--- a/VisualEditor.php
+++ b/VisualEditor.php
@@ -529,6 +529,7 @@
'visualeditor-dialog-meta-title',
'visualeditor-dialog-meta-categories-section',
'visualeditor-dialog-meta-categories-data-label',
+ 'visualeditor-dialog-meta-categories-category',
'visualeditor-dialog-meta-categories-options',
'visualeditor-dialog-meta-categories-input-placeholder',
'visualeditor-dialog-meta-categories-input-newcategorylabel',
diff --git a/modules/ve/ui/styles/ve.ui.Widget.css
b/modules/ve/ui/styles/ve.ui.Widget.css
index 9405f06..63bf22b 100644
--- a/modules/ve/ui/styles/ve.ui.Widget.css
+++ b/modules/ve/ui/styles/ve.ui.Widget.css
@@ -511,8 +511,8 @@
.ve-ui-mwCategoryPopupTitle {
background-position: left center;
background-repeat: no-repeat;
- padding: 0.125em 0.5em 0.5em 2.25em;
- margin: 0 0 1em 0.125em;
+ padding: 0.5em 0.5em 0.5em 2.25em;
+ margin: -0.4em 0 1em 0.125em;
}
.ve-ui-mwCategoryPopupMenu .ve-ui-removeButtonLabel:hover {
diff --git a/modules/ve/ui/widgets/ve.ui.MWCategoryPopupWidget.js
b/modules/ve/ui/widgets/ve.ui.MWCategoryPopupWidget.js
index a62d916..1b8d238 100644
--- a/modules/ve/ui/widgets/ve.ui.MWCategoryPopupWidget.js
+++ b/modules/ve/ui/widgets/ve.ui.MWCategoryPopupWidget.js
@@ -46,7 +46,7 @@
this.$.addClass( 've-ui-mwCategoryPopupMenu' ).hide();
this.$title
.addClass( 've-ui-mwCategoryPopupTitle ve-ui-icon-tag' )
- .text( ve.msg(
'visualeditor-dialog-meta-categories-settings-label' ) );
+ .text( ve.msg( 'visualeditor-dialog-meta-categories-category' )
);
this.$menu.append(
this.$title,
this.removeButton.$.addClass( 've-ui-mwCategoryRemoveButton' ),
--
To view, visit https://gerrit.wikimedia.org/r/68129
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia8051125bbc9bde47ceb931e1ebf42b2955481ff
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Trevor Parscal <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
