Tim Landscheidt has uploaded a new change for review.
https://gerrit.wikimedia.org/r/68331
Change subject: Fix variable declaration and enable warnings in job.
......................................................................
Fix variable declaration and enable warnings in job.
Change-Id: I5c674e2b201a140153fdb950c82f254e106407c9
---
M jobutils/bin/job
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/labs/toollabs
refs/changes/31/68331/1
diff --git a/jobutils/bin/job b/jobutils/bin/job
index f8e697e..083281f 100755
--- a/jobutils/bin/job
+++ b/jobutils/bin/job
@@ -1,4 +1,4 @@
-#! /usr/bin/perl
+#!/usr/bin/perl -w
#
# Copyright © 2013 Marc-André Pelletier <mpellet...@wikimedia.org>
#
@@ -14,6 +14,9 @@
# ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
# OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
#
+
+use strict;
+use warnings;
my $mode;
$mode = shift if $#ARGV>0 and $ARGV[0] eq '-v';
@@ -38,7 +41,7 @@
my $name = shift;
-my $jnum, $jname, $jstate, $jstart;
+my ($jnum, $jname, $jstate, $jstart);
open XML, "/usr/bin/qstat -xml|" or die "qstat: $!";
while(<XML>) {
--
To view, visit https://gerrit.wikimedia.org/r/68331
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5c674e2b201a140153fdb950c82f254e106407c9
Gerrit-PatchSet: 1
Gerrit-Project: labs/toollabs
Gerrit-Branch: master
Gerrit-Owner: Tim Landscheidt <t...@tim-landscheidt.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
