jenkins-bot has submitted this change and it was merged. Change subject: Remove obsolete TODO and improve codeCoverageIgnore usage ......................................................................
Remove obsolete TODO and improve codeCoverageIgnore usage Change-Id: I6b8c986c416c361320822708b567ab28d22b2d45 --- M Ask.mw.php M Ask.php 2 files changed, 1 insertion(+), 4 deletions(-) Approvals: Daniel Kinzler: Looks good to me, approved jenkins-bot: Verified diff --git a/Ask.mw.php b/Ask.mw.php index f266317..fdd05c9 100644 --- a/Ask.mw.php +++ b/Ask.mw.php @@ -46,7 +46,7 @@ * Hook to add PHPUnit test cases. * @see https://www.mediawiki.org/wiki/Manual:Hooks/UnitTestsList * - * TODO: register the Tests directory itself so this list does not need to be maintained + * @codeCoverageIgnore * * @since 0.1 * @@ -55,7 +55,6 @@ * @return boolean */ $wgHooks['UnitTestsList'][] = function( array &$files ) { - // @codeCoverageIgnoreStart $directoryIterator = new RecursiveDirectoryIterator( __DIR__ . '/Tests/Phpunit/' ); /** @@ -68,5 +67,4 @@ } return true; - // @codeCoverageIgnoreEnd }; diff --git a/Ask.php b/Ask.php index 68296ec..80845f6 100644 --- a/Ask.php +++ b/Ask.php @@ -75,5 +75,4 @@ require_once __DIR__ . '/Ask.mw.php'; } ); } - // @codeCoverageIgnoreEnd \ No newline at end of file -- To view, visit https://gerrit.wikimedia.org/r/67346 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b8c986c416c361320822708b567ab28d22b2d45 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Ask Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw <[email protected]> Gerrit-Reviewer: Daniel Kinzler <[email protected]> Gerrit-Reviewer: Daniel Werner <[email protected]> Gerrit-Reviewer: Tobias Gritschacher <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
