Yaron Koren has submitted this change and it was merged.
Change subject: Correct email validation
......................................................................
Correct email validation
Change-Id: I84f55012e7f7a102b4218966f0395936540dc06e
---
M includes/SES_UserAccountDataChecker.php
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Yaron Koren: Verified; Looks good to me, approved
jenkins-bot: Checked
diff --git a/includes/SES_UserAccountDataChecker.php
b/includes/SES_UserAccountDataChecker.php
index 2c88744..7ee84ce 100644
--- a/includes/SES_UserAccountDataChecker.php
+++ b/includes/SES_UserAccountDataChecker.php
@@ -96,8 +96,9 @@
public function checkEmailValidity()
{
global $wgEnableEmail;
- if ( $wgEnableEmail && !User::isValidEmailAddr( $this->mEmail )
)
+ if ( $wgEnableEmail && $this->mEmail !== '' &&
!Sanitizer::validateEmail( $this->mEmail ) ) {
$this->error( wfMsg( 'invalidemailaddress' ) );
+ }
}
public function __construct()
--
To view, visit https://gerrit.wikimedia.org/r/68342
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I84f55012e7f7a102b4218966f0395936540dc06e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticSignup
Gerrit-Branch: master
Gerrit-Owner: Nischayn22 <nischay...@gmail.com>
Gerrit-Reviewer: Yaron Koren <yaro...@gmail.com>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
