Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/68578
Change subject: Bug 49276: Disable accidental clicking of links in preview
......................................................................
Bug 49276: Disable accidental clicking of links in preview
Change-Id: I3502730573e0ce8e4dd08bfd990f46834168d5fc
---
M javascripts/modules/editor/PreviewOverlay.js
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/78/68578/1
diff --git a/javascripts/modules/editor/PreviewOverlay.js
b/javascripts/modules/editor/PreviewOverlay.js
index fa57e98..2a156e3 100644
--- a/javascripts/modules/editor/PreviewOverlay.js
+++ b/javascripts/modules/editor/PreviewOverlay.js
@@ -38,7 +38,7 @@
d.done( function( parsedText ) {
// FIXME: hacky
- var $tmp = $( '<div>' ).html( parsedText ),
heading;
+ var $tmp = $( '<div>' ).html( parsedText ),
heading, preview;
// FIXME: yuck.
$tmp.find( '.mw-editsection' ).remove();
// Extract the first heading
@@ -47,13 +47,15 @@
// remove heading from the parsed output
$tmp.find( 'h2' ).eq( 0 ).remove();
- new Section( {
+ preview = new Section( {
el: $container,
index: 'preview',
// doesn't account for headings with
html inside
heading: heading,
content: $tmp.html()
} );
+ // bug 49218: stop links from being clickable
(note user can still hold down to navigate to them)
+ preview.$( 'a' ).on( 'click', false );
// Emit event so we can perform enhancements to
page
M.emit( 'edit-preview', self );
} ).fail( function() {
--
To view, visit https://gerrit.wikimedia.org/r/68578
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3502730573e0ce8e4dd08bfd990f46834168d5fc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
