Henning Snater has uploaded a new change for review.
https://gerrit.wikimedia.org/r/68619
Change subject: Require only required parameters in GeoCoordinateValue's
newFromArray
......................................................................
Require only required parameters in GeoCoordinateValue's newFromArray
Change-Id: Idea6d5395afdb2a32cd70ba389097c58718b6ba5
---
M DataValues/includes/values/GeoCoordinateValue.php
1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DataValues
refs/changes/19/68619/1
diff --git a/DataValues/includes/values/GeoCoordinateValue.php
b/DataValues/includes/values/GeoCoordinateValue.php
index d1e4fb8..e984cfd 100644
--- a/DataValues/includes/values/GeoCoordinateValue.php
+++ b/DataValues/includes/values/GeoCoordinateValue.php
@@ -81,7 +81,7 @@
* @param float|int $latitude
* @param float|int $longitude
* @param float|int|null $altitude
- * param float|int|null $precision
+ * @param float|int|null $precision
* @param string|null $globe
*
* @throws IllegalValueException
@@ -278,14 +278,14 @@
* @throws IllegalValueException
*/
public static function newFromArray( $data ) {
- self::requireArrayFields( $data, array( 'latitude',
'longitude', 'altitude', 'precision', 'globe' ) );
+ self::requireArrayFields( $data, array( 'latitude', 'longitude'
) );
return new static(
$data['latitude'],
$data['longitude'],
- $data['altitude'],
- $data['precision'],
- $data['globe']
+ ( isset( $data['altitude'] ) ) ? $data['altitude'] :
null,
+ ( isset( $data['precision'] ) ) ? $data['precision'] :
null,
+ ( isset( $data['globe'] ) ) ? $data['globe'] :
'http://www.wikidata.org/entity/Q2'
);
}
--
To view, visit https://gerrit.wikimedia.org/r/68619
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idea6d5395afdb2a32cd70ba389097c58718b6ba5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataValues
Gerrit-Branch: master
Gerrit-Owner: Henning Snater <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
