Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/68631
Change subject: Cleanup grunt temp files properly.
......................................................................
Cleanup grunt temp files properly.
Move post-qunit task to qunit.done event which fires on success
or failure.
Define pre-qunit + qunit as a group test 'unittests', so they can be
run from the command line (previously 'grunt qunit' would fail) as
'grunt unittests'.
Also add override comment to css file using non-standard property so
csslint doesn't fail.
Bug: 49431
Change-Id: I5079d00a63d43276a12dd78c306bb3819470631d
---
M Gruntfile.js
M modules/ve/ui/styles/ve.ui.Widget.css
2 files changed, 5 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/31/68631/1
diff --git a/Gruntfile.js b/Gruntfile.js
index f46f1ac..0e48e88 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -50,11 +50,11 @@
} );
} );
- grunt.registerTask( 'post-qunit', function () {
+ grunt.event.on( 'qunit.done', function () {
fs.unlinkSync( __dirname +
'/modules/ve/test/index-phantomjs-tmp.html' );
- return true;
} );
- grunt.registerTask( 'test', ['jshint', 'csslint', 'pre-qunit', 'qunit',
'post-qunit'] );
- grunt.registerTask( 'default', 'test' );
+ grunt.registerTask( 'unittests', ['pre-qunit', 'qunit'] );
+ grunt.registerTask( 'all', ['jshint', 'csslint', 'unittests'] );
+ grunt.registerTask( 'default', 'all' );
};
diff --git a/modules/ve/ui/styles/ve.ui.Widget.css
b/modules/ve/ui/styles/ve.ui.Widget.css
index 33ee614..79ccba9 100644
--- a/modules/ve/ui/styles/ve.ui.Widget.css
+++ b/modules/ve/ui/styles/ve.ui.Widget.css
@@ -397,6 +397,7 @@
* word-break: break-word; (which is not documented in any standard at
all). So we just use
* all three.
*/
+ /*csslint known-properties:false */
word-break: break-word;
word-wrap: break-word;
overflow-wrap: break-word;
--
To view, visit https://gerrit.wikimedia.org/r/68631
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5079d00a63d43276a12dd78c306bb3819470631d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
