jenkins-bot has submitted this change and it was merged.
Change subject: Make the link to undo language change usable
......................................................................
Make the link to undo language change usable
Fix bug: Link to revert to the earlier display language inside the tooltip
cannot
be clicked. It was hiding on mouse over.
Bug: 49556
Change-Id: If536142fd61aa191601262dbfec6de960c167081
---
M resources/js/ext.uls.interface.js
1 file changed, 6 insertions(+), 9 deletions(-)
Approvals:
Nikerabbit: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/js/ext.uls.interface.js
b/resources/js/ext.uls.interface.js
index 2bf1123..fe60811 100644
--- a/resources/js/ext.uls.interface.js
+++ b/resources/js/ext.uls.interface.js
@@ -131,14 +131,14 @@
previousLang = previousLanguages.slice( -1 )[0];
+ $ulsTrigger = ( ulsPosition === 'interlanguage' ) ?
+ $( '.uls-settings-trigger' ) :
+ $( '.uls-trigger' );
+
if ( previousLang === currentLang ) {
- // Do not show tooltip nor update language list
+ $ulsTrigger.tipsy( { gravity: rtlPage ? 'e' : 'w' } );
return true;
}
-
- $ulsTrigger = ( ulsPosition === 'interlanguage' ) ?
- $( '.uls-settings-trigger' ) :
- $( '.uls-trigger' );
previousLanguages.push( currentLang );
mw.uls.setPreviousLanguages( previousLanguages );
@@ -151,8 +151,6 @@
return true;
}
- // Remove existing tipsy tooltip
- $ulsTrigger.removeData( 'tipsy' );
// Attach a tipsy tooltip to the trigger
$ulsTrigger.tipsy( {
gravity: tipsyGravity[ulsPosition],
@@ -244,8 +242,7 @@
// Add an element near the interlanguage links header
$ulsSettingsTrigger = $( '<span>' )
.addClass( 'uls-settings-trigger' )
- .attr( 'title', $.i18n(
'ext-uls-language-settings-title' ) )
- .tipsy( { gravity: rtlPage ? 'e' : 'w' } );
+ .attr( 'title', $.i18n(
'ext-uls-language-settings-title' ) );
// Append ULS cog to languages section. But make sure
it is visible.
$pLang.show().prepend( $ulsSettingsTrigger );
--
To view, visit https://gerrit.wikimedia.org/r/68616
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If536142fd61aa191601262dbfec6de960c167081
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Santhosh <[email protected]>
Gerrit-Reviewer: Amire80 <[email protected]>
Gerrit-Reviewer: KartikMistry <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: Santhosh <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
