Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/68712
Change subject: Log user ID; 'pageViewSessionId' to alphanum string
......................................................................
Log user ID; 'pageViewSessionId' to alphanum string
By default, EventLogging uses INT columns for integers, which pageViewSessionId
overflows. I changed it to a STRING type in the schema and am now generating it
using 'mw.user.generateRandomSessionId()'. I also introduced a 'userId'
property, per bug 49585.
Bug: 49585
Bug: 49586
Change-Id: Iddb9eb9c64b55b25445ddf9e474d312b685978a6
---
M VisualEditor.hooks.php
M modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
2 files changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/12/68712/1
diff --git a/VisualEditor.hooks.php b/VisualEditor.hooks.php
index 29d94dd..34dfa4d 100644
--- a/VisualEditor.hooks.php
+++ b/VisualEditor.hooks.php
@@ -22,7 +22,7 @@
$wgResourceModules['schema.Edit'] = array(
'class' =>
'ResourceLoaderSchemaModule',
'schema' => 'Edit',
- 'revision' => 5563071,
+ 'revision' => 5570274,
);
} else {
wfWarn( 'VisualEditor is configured to use
EventLogging, but the extension is ' .
diff --git a/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
b/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
index 502c55a..ddde3f4 100644
--- a/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
+++ b/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
@@ -847,10 +847,11 @@
pageId: mw.config.get( 'wgArticleId' ),
pageNs: mw.config.get( 'wgNamespaceNumber' ),
pageName: mw.config.get( 'wgPageName' ),
- pageViewSessionId: +new Date(),
+ pageViewSessionId: mw.user.generateRandomSessionId(),
revId: function () {
return mw.config.get( 'wgCurRevisionId' );
- }
+ },
+ userId: +mw.config.get( 'wgUserId' )
} );
} );
};
--
To view, visit https://gerrit.wikimedia.org/r/68712
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iddb9eb9c64b55b25445ddf9e474d312b685978a6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
