Subramanya Sastry has uploaded a new change for review.
https://gerrit.wikimedia.org/r/69124
Change subject: Ugh! Fix a crasher when dsr is missing (bug from c28f1370)
......................................................................
Ugh! Fix a crasher when dsr is missing (bug from c28f1370)
ja:イグエーニャthat crashed during RT testing now fixed.
Change-Id: Ib875b48b4de3251e9c875b5dcc33df9f69e1835d
---
M js/lib/mediawiki.DOMPostProcessor.js
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid
refs/changes/24/69124/1
diff --git a/js/lib/mediawiki.DOMPostProcessor.js
b/js/lib/mediawiki.DOMPostProcessor.js
index a63beee..91263e8 100644
--- a/js/lib/mediawiki.DOMPostProcessor.js
+++ b/js/lib/mediawiki.DOMPostProcessor.js
@@ -2510,8 +2510,12 @@
if (!firstChild.data.parsoid) {
console.log(node.data.parsoid,
dummyNode.outerHTML);
}
+
var dsr = node.data.parsoid.dsr;
- firstChild.data.parsoid.dsr = [dsr[0], dsr[1]];
+ // FIXME: Not sure why this would be missing
+ if (dsr) {
+ firstChild.data.parsoid.dsr = [dsr[0], dsr[1]];
+ }
// FIXME: Deal with the case where the DOMFragment node
is also a
// transclusion. OTOH, dp.html should not be available
in that case,
--
To view, visit https://gerrit.wikimedia.org/r/69124
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib875b48b4de3251e9c875b5dcc33df9f69e1835d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
