jenkins-bot has submitted this change and it was merged.
Change subject: Update docs and type hints
......................................................................
Update docs and type hints
Change-Id: I6c513265d7e3136c43c160b86a83a921defaa3ec
---
M ResourceLoaderULSModule.php
M UniversalLanguageSelector.hooks.php
M UniversalLanguageSelector.php
3 files changed, 13 insertions(+), 6 deletions(-)
Approvals:
Santhosh: Looks good to me, approved
jenkins-bot: Verified
diff --git a/ResourceLoaderULSModule.php b/ResourceLoaderULSModule.php
index 784db4f..895b06d 100644
--- a/ResourceLoaderULSModule.php
+++ b/ResourceLoaderULSModule.php
@@ -23,6 +23,9 @@
* Resource loader module for providing MediaWiki language names.
*/
class ResourceLoaderULSModule extends ResourceLoaderModule {
+ /**
+ * @var Language
+ */
protected $language;
protected $targets = array( 'desktop', 'mobile' );
diff --git a/UniversalLanguageSelector.hooks.php
b/UniversalLanguageSelector.hooks.php
index 6b0f8e5..468856b 100644
--- a/UniversalLanguageSelector.hooks.php
+++ b/UniversalLanguageSelector.hooks.php
@@ -21,6 +21,8 @@
class UniversalLanguageSelectorHooks {
/**
* Whether ULS user toolbar (language selection and settings) is
enabled.
+ *
+ * @param User $user
* @return bool
*/
public static function isToolbarEnabled( $user ) {
@@ -35,8 +37,8 @@
}
/**
- * @param $out OutputPage
- * @param $skin Skin
+ * @param OutputPage $out
+ * @param Skin $skin
* @return bool
* Hook: BeforePageDisplay
*/
@@ -64,7 +66,7 @@
/**
* @param $testModules array of javascript testing modules. 'qunit' is
fed
* using tests/qunit/QUnitTestResources.php.
- * @param $resourceLoader ResourceLoader
+ * @param ResourceLoader $resourceLoader
* @return bool
* Hook: ResourceLoaderTestModules
*/
@@ -158,8 +160,9 @@
/**
* Hook to UserGetLanguageObject
- * @param $user User
- * @param $code String
+ * @param User $user
+ * @param string $code
+ * @param RequestContext $context Optional RequestContext
* @return bool
*/
public static function getLanguage( $user, &$code, $context = null ) {
@@ -239,7 +242,7 @@
/**
* Hook: ResourceLoaderGetConfigVars
- * @param $vars Array
+ * @param array $vars
* @return bool
*/
public static function addConfig( &$vars ) {
diff --git a/UniversalLanguageSelector.php b/UniversalLanguageSelector.php
index 3583b39..069fe7d 100644
--- a/UniversalLanguageSelector.php
+++ b/UniversalLanguageSelector.php
@@ -146,6 +146,7 @@
if ( $wgULSGeoService === true ) {
$wgHooks['BeforePageDisplay'][] = function( &$out ) {
+ /** @var OutputPage $out */
$out->addScript( '<script
src="//bits.wikimedia.org/geoiplookup"></script>' );
return true;
};
--
To view, visit https://gerrit.wikimedia.org/r/69102
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c513265d7e3136c43c160b86a83a921defaa3ec
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Siebrand <[email protected]>
Gerrit-Reviewer: Amire80 <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: Santhosh <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
