Njw has submitted this change and it was merged. Change subject: Remove unnecessary custom line-heights to simplify the code ......................................................................
Remove unnecessary custom line-heights to simplify the code Change-Id: I54b296062dfa77405def55c68d4a87831c2481e6 --- M TODO M assets/erudite.css 2 files changed, 6 insertions(+), 13 deletions(-) Approvals: Njw: Verified; Looks good to me, approved diff --git a/TODO b/TODO index 6b024ed..8a1f312 100644 --- a/TODO +++ b/TODO @@ -1,3 +1,2 @@ Test that it works fine with ULS extension Use simpler CSS rules for main content, rather than children of .entry-content -Set line-height consistently throughout (and ensure it isn't used in lieu of padding) diff --git a/assets/erudite.css b/assets/erudite.css index 6a19d27..cfdcd06 100644 --- a/assets/erudite.css +++ b/assets/erudite.css @@ -60,32 +60,28 @@ h1 { font-size: 1.5em; text-transform: uppercase; - line-height: 1; letter-spacing: 0.05em; - margin: 1.3em 0 0.3em; + margin-top: 1.3em; } h2 { font-size: 1.25em; - line-height: 1.1; - margin: 1em 0 0.25em; + margin-top: 1em; } h3 { font-size: 1.2em; - line-height: 1.2; - margin: 1.15em 0 0.3em; + margin-top: 1.15em; } h4 { font-size: 1.1em; - line-height: 1.3; - margin: 1.3em 0 0.3em; + margin-top: 1.3em; } h5 { font-size: 1em; - margin-top: 1.5em 0 0.375em; + margin-top: 1.5em; } h1 + h2, @@ -200,6 +196,7 @@ .footer h3 { border-bottom: 1px solid #666666; + margin-bottom: 0.2em; font-size: 1.25em; text-transform: uppercase; letter-spacing: 0.05em; @@ -251,7 +248,6 @@ .entry-title { color: #555555; margin: 0 0 0.5em; - line-height: 1.5; } .entry-content p, @@ -426,7 +422,6 @@ padding: 3px !important; background-color: #f9f9f9; font-size: 0.875em; - line-height: 1.4; text-align: center; overflow: hidden; } @@ -507,7 +502,6 @@ #catlinks a { color: #ffffff; padding: 0 1em; - line-height: 2; height: 100%; font-size: 0.75em; display: inline; -- To view, visit https://gerrit.wikimedia.org/r/69134 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54b296062dfa77405def55c68d4a87831c2481e6 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/skins/erudite Gerrit-Branch: master Gerrit-Owner: Njw <nick.wh...@durham.ac.uk> Gerrit-Reviewer: Njw <nick.wh...@durham.ac.uk> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits