GWicke has uploaded a new change for review.
https://gerrit.wikimedia.org/r/69258
Change subject: Bug 49503: Document missing round-tripping of redirect to
category
......................................................................
Bug 49503: Document missing round-tripping of redirect to category
Change-Id: Id1a79fe8366a9386191b919c2ce446fbf56d4863
---
M js/lib/ext.core.LinkHandler.js
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid
refs/changes/58/69258/1
diff --git a/js/lib/ext.core.LinkHandler.js b/js/lib/ext.core.LinkHandler.js
index 129f78b..38f0893 100644
--- a/js/lib/ext.core.LinkHandler.js
+++ b/js/lib/ext.core.LinkHandler.js
@@ -200,6 +200,11 @@
// For '#REDIRECT [[Category:Foo]] we've already "used
up" our
// tsr on the #REDIRECT part. Use a zero-width DSR
here to
// note that this part is synthetic and to disable
selser.
+ //
+ // Also, this won't round-trip without selser. Instead
it will
+ // duplicate [[Category:Foo]] on each round-trip. As
these
+ // redirects should really be to [[:Category:Foo]]
these cases
+ // should be rare enough to not add much noise in rt
testing.
if ( redirect ) { delete obj.dataAttribs.tsr; }
tokens.push( obj );
--
To view, visit https://gerrit.wikimedia.org/r/69258
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id1a79fe8366a9386191b919c2ce446fbf56d4863
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: GWicke <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
