Catrope has uploaded a new change for review.
https://gerrit.wikimedia.org/r/69266
Change subject: Failing test case for 95733390dc87894fe85b3479a9268fe2d797b26e
......................................................................
Failing test case for 95733390dc87894fe85b3479a9268fe2d797b26e
Change-Id: I8c2e239e945466f3e46c92efab03f7e615bc6887
---
M modules/ve/test/dm/ve.dm.example.js
1 file changed, 81 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/66/69266/1
diff --git a/modules/ve/test/dm/ve.dm.example.js
b/modules/ve/test/dm/ve.dm.example.js
index f106ee9..56d092e 100644
--- a/modules/ve/test/dm/ve.dm.example.js
+++ b/modules/ve/test/dm/ve.dm.example.js
@@ -3161,6 +3161,87 @@
{ 'type': 'internalList' },
{ 'type': '/internalList' }
]
+ },
+ 'attribute preservation does not crash due to text node split': {
+ 'html': '<body><figure typeof="mw:Image/Thumb"
data-parsoid="{}"><a rel="mw:thumb" href="Foo" data-parsoid="{}"><img src="Bar"
width="1" height="2" resource="FooBar" data-parsoid="{}"></a><figcaption
class="mw-figcaption" data-parsoid="{}"> foo <a rel="mw:WikiLink" href="./Bar"
data-parsoid="{}">bar</a> baz</figcaption></figure></body>',
+ 'data': [
+ {
+ 'type': 'mwBlockImage',
+ 'attributes': {
+ 'type': 'thumb',
+ 'align': 'default',
+ 'href': 'Foo',
+ 'src': 'Bar',
+ 'width': '1',
+ 'height': '2',
+ 'resource': 'FooBar'
+ },
+ 'htmlAttributes': [ {
+ 'values': { 'data-parsoid': '{}' },
+ 'children': [
+ {
+ 'values': {
'data-parsoid': '{}' },
+ 'children': [ {
+ 'values': {
'data-parsoid': '{}' }
+ } ]
+ },
+ {
+ 'values': {
'data-parsoid': '{}' },
+ 'children': [
+ { 'values': {}
},
+ { 'values': {
'data-parsoid': '{}' } },
+ { 'values': {} }
+ ]
+ }
+ ]
+ } ]
+ },
+ { 'type': 'mwImageCaption', 'internal': { 'whitespace':
[ undefined, ' ' ] } },
+ { 'type': 'paragraph', 'internal': { 'generated':
'wrapper', 'whitespace': [ ' ' ] } },
+ 'f', 'o', 'o', ' ',
+ [
+ 'b',
+ [ {
+ 'type': 'link/mwInternal',
+ 'attributes': {
+ 'title': 'Bar',
+ 'origTitle': 'Bar',
+ 'hrefPrefix': './'
+ },
+ 'htmlAttributes': [ { 'values': {
'href': './Bar', 'rel': 'mw:WikiLink', 'data-parsoid': '{}' } } ]
+ } ]
+ ],
+ [
+ 'a',
+ [ {
+ 'type': 'link/mwInternal',
+ 'attributes': {
+ 'title': 'Bar',
+ 'origTitle': 'Bar',
+ 'hrefPrefix': './'
+ },
+ 'htmlAttributes': [ { 'values': {
'href': './Bar', 'rel': 'mw:WikiLink', 'data-parsoid': '{}' } } ]
+ } ]
+ ],
+ [
+ 'r',
+ [ {
+ 'type': 'link/mwInternal',
+ 'attributes': {
+ 'title': 'Bar',
+ 'origTitle': 'Bar',
+ 'hrefPrefix': './'
+ },
+ 'htmlAttributes': [ { 'values': {
'href': './Bar', 'rel': 'mw:WikiLink', 'data-parsoid': '{}' } } ]
+ } ]
+ ],
+ ' ', 'b', 'a', 'z',
+ { 'type': '/paragraph' },
+ { 'type': '/mwImageCaption' },
+ { 'type': '/mwBlockImage' },
+ { 'type': 'internalList' },
+ { 'type': '/internalList' }
+ ]
}
};
--
To view, visit https://gerrit.wikimedia.org/r/69266
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8c2e239e945466f3e46c92efab03f7e615bc6887
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
