jenkins-bot has submitted this change and it was merged.
Change subject: Fix fatal error on user registration due to hook fail
......................................................................
Fix fatal error on user registration due to hook fail
Hooks need to return true if they succeed. Fatal errors in production.
Change-Id: Ie5ec5881a8d158bd675dbb6db4540f02fd33290d
---
M VisualEditor.hooks.php
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Ori.livneh: Looks good to me, approved
Spage: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/VisualEditor.hooks.php b/VisualEditor.hooks.php
index 45e9db6..9c9f2f3 100644
--- a/VisualEditor.hooks.php
+++ b/VisualEditor.hooks.php
@@ -208,5 +208,7 @@
$user->setOption( 'visualeditor-enable', 1 );
$user->saveSettings();
}
+
+ return true;
}
}
--
To view, visit https://gerrit.wikimedia.org/r/69277
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie5ec5881a8d158bd675dbb6db4540f02fd33290d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: MarkTraceur <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: Spage <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
