jenkins-bot has submitted this change and it was merged.
Change subject: Pass along tagFilter to ContribsPager, it already expects it
......................................................................
Pass along tagFilter to ContribsPager, it already expects it
ContribsPager already has this below line:
$this->tagFilter = isset( $options['tagfilter'] ) ? $options['tagfilter'] :
false;
The reason the code already works fine is because, in ChangeTags.php, there's
this fallback:
if ( $filter_tag === false ) {
$filter_tag = $wgRequest->getVal( 'tagfilter' );
}
Which essentially boils down to the same result as passing along tagfilter,
which in
SpecialContributions is read from $wgRequest, passed to ContribsPager, and
(well, currently
not) passed to ChangeTags
Change-Id: I12c0336ae31c5524e41fa0087afe2ba104dc7d37
---
M includes/specials/SpecialContributions.php
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Alex Monk: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/specials/SpecialContributions.php
b/includes/specials/SpecialContributions.php
index 21becd6..2f37cb4 100644
--- a/includes/specials/SpecialContributions.php
+++ b/includes/specials/SpecialContributions.php
@@ -175,6 +175,7 @@
'target' => $target,
'contribs' => $this->opts['contribs'],
'namespace' => $this->opts['namespace'],
+ 'tagfilter' => $this->opts['tagfilter'],
'year' => $this->opts['year'],
'month' => $this->opts['month'],
'deletedOnly' => $this->opts['deletedOnly'],
--
To view, visit https://gerrit.wikimedia.org/r/69153
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I12c0336ae31c5524e41fa0087afe2ba104dc7d37
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie <[email protected]>
Gerrit-Reviewer: Alex Monk <[email protected]>
Gerrit-Reviewer: Nemo bis <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
