jenkins-bot has submitted this change and it was merged.
Change subject: Ignore shortcut keys inside key press handler
......................................................................
Ignore shortcut keys inside key press handler
Bug: 49732
Bug: 49760
Bug: 49816
Change-Id: I8f814a0f369c470038896041f157b3dbd0d7f1a7
---
M modules/ve/ce/ve.ce.Surface.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/ce/ve.ce.Surface.js b/modules/ve/ce/ve.ce.Surface.js
index 1fbea19..24ed81c 100644
--- a/modules/ve/ce/ve.ce.Surface.js
+++ b/modules/ve/ce/ve.ce.Surface.js
@@ -495,7 +495,7 @@
// deletion would occur in case when selection is not collapsed and
user press home key for
// instance (Firefox fires keypress for home key).
// TODO: Should be covered with Selenium tests.
- if ( e.which === 0 || e.charCode === 0 ) {
+ if ( e.which === 0 || e.charCode === 0 || ve.ce.isShortcutKey( e ) ) {
return;
}
--
To view, visit https://gerrit.wikimedia.org/r/69503
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f814a0f369c470038896041f157b3dbd0d7f1a7
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Inez <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Christian <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
