Nikerabbit has uploaded a new change for review.
https://gerrit.wikimedia.org/r/69634
Change subject: Stricter parsing for external links in JavaScript
......................................................................
Stricter parsing for external links in JavaScript
Bug: 49850
Change-Id: If7337cb1a9b729c511adb32d8a2326ea17a8160c
---
M resources/js/ext.translate.parsers.js
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate
refs/changes/34/69634/1
diff --git a/resources/js/ext.translate.parsers.js
b/resources/js/ext.translate.parsers.js
index 4bceda3..5293721 100644
--- a/resources/js/ext.translate.parsers.js
+++ b/resources/js/ext.translate.parsers.js
@@ -19,6 +19,9 @@
* @return {String} Formatted text in html
*/
formatMessageGently: function ( text, key ) {
+ var externals,
+ protocols = mw.config.get( 'wgUrlProtocols' );
+
// Try to keep simple.
text = $( '<div>' ).text( text ).html();
@@ -56,8 +59,9 @@
return $( '<div>' ).append( link ).html();
} );
- text = text.replace( /\[([^ ]+) (.+?)\]/g, function (
match, p1, p2 ) {
- var link = $( '<a>' ).html( p2 ).prop( 'href',
p1 );
+ externals = new RegExp( '\\[((' + protocols + ')[^ ]+)
(.+?)\\]', 'g');
+ text = text.replace( externals, function ( match, p1,
p2, p3 ) {
+ var link = $( '<a>' ).html( p3 ).prop( 'href',
p1 );
return $( '<div>' ).append( link ).html();
} );
--
To view, visit https://gerrit.wikimedia.org/r/69634
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If7337cb1a9b729c511adb32d8a2326ea17a8160c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
